Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13853] Remove unused file that bewilder CMake find mechanism #57

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Feb 22, 2022

The faulty scenario is the following:

> git clone https://github.com/eProsima/foonathan_memory_vendor.git
> cmake -DCMAKE_INSTALL_PREFIX="./install" -B ./foonathan_memory_vendor/build ./foonathan_memory_vendor 
> cmake --build ./foonathan_memory_vendor/build --config Release --target install 

here the CMake generator stage finds the foonathan_memory-config.cmake within the repo as a valid installation breaking the build.

Note that unfortunately the file location matches the following CMake search procedure case

<prefix>/<name>*/                                               (W)

because foonathan_memory_vendor matches foonathan_memory*.

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro self-assigned this Feb 22, 2022
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro MiguelBarro merged commit 5bf0a40 into master Feb 22, 2022
@MiguelCompany MiguelCompany deleted the bugfix/trim branch February 22, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants