forked from ros2/rosidl_typesupport_fastrtps
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20676] Support for Topic Keys (rolling) #6
Open
Mario-DL
wants to merge
7
commits into
rolling
Choose a base branch
from
feature/rolling/keys
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
March 29, 2024 11:16
5373997
to
1cf0e8a
Compare
MiguelCompany
requested changes
Mar 29, 2024
rosidl_typesupport_fastrtps_cpp/include/rosidl_typesupport_fastrtps_cpp/message_type_support.h
Outdated
Show resolved
Hide resolved
Mario-DL
force-pushed
the
feature/rolling/keys
branch
from
April 1, 2024 10:48
d1aea89
to
0234c9b
Compare
MiguelCompany
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amend last commit removing file test_cli_extension.cpython-310-pytest-6.2.5.pyc
Mario-DL
force-pushed
the
feature/rolling/keys
branch
from
April 1, 2024 13:38
0234c9b
to
58c68bc
Compare
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
MiguelCompany
force-pushed
the
feature/rolling/keys
branch
from
April 7, 2024 11:04
7dffcb9
to
61072ed
Compare
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the necessary changes to support
Topic Keys
into ROS 2rolling