Fix pcrglob #2
Merged
Fix pcrglob #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
geek-yang
reviewed
Dec 8, 2023
| @@ -27,9 +27,20 @@ | |||
| }, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah that's correct.
I think the old pcrglob didn't have version numbers and the tags of the old containers aren't numbered but named...
There was a problem hiding this comment.
😂 You are on holiday right? Who said that he was not a workaholic? Just stop working and enjoy your long weekend!
geek-yang
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OptionalDestBMI from grpc4bmi broke things, because the old pcrglobwb model did not have all methods implemented correctly:
get_grid_sizeis missing, which can be circumvented throughget_grid_shape.This leads to basically all util methods breaking, as well as
_bmi.get_valueif you don't specify a dest array.By overwriting the eWaterCycle methods that make use of these, we can circumvent the problem.