Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] dashboard is dead; long live dashboard #2408

Closed
wants to merge 1 commit into from

Conversation

joewiz
Copy link
Member

@joewiz joewiz commented Jan 21, 2019

Description:

  • This PR replaces the old dashboard with the new dashboard for the purpose of populating the autodeploy directory during a normal and installer builds.
  • It also updates the webapp default redirect of requests for "/" to "/exist/apps/existdb-dashboard" and similarly updates the URL associated with dashboard in the menubar/taskbar and tool window.

Many developers have been using and testing the new dashboard and, as discussed in the January 7, 2018 community call, recommend that the new dashboard be included in the next 5.0.0-RC. (There are no current plans to backport this to the 4.x.x series.)

Reference:

Type of tests:

  • I tested regular and installer builds and confirmed that with these PR changes, eXist starts correctly; the new dashboard loads; all panes in the app open without error; the new dashboard is the target of the redirect when requesting "/"; and the new dashboard is the target when selecting dashboard entries from menubar/taskbar and tool window.

@joewiz joewiz added enhancement new features, suggestions, etc. needs 5.x.x backport labels Jan 21, 2019
@joewiz joewiz added this to the eXist-5.0.0-RC6 milestone Jan 21, 2019
@adamretter
Copy link
Contributor

One concern, is that the URLs are changing, this applies to anyone who has given out a URL to their Dashboard website or to the public website Dashboard, e.g.

http://www.exist-db.org/exist/apps/dashboard/index.html is becoming http://www.exist-db.org/exist/apps/existdb-dashboard/index.html.

I think that's a bad thing. If the new Dashboard is final, why don't we just import the code into the old repo. Git will save everything for us so we can always go back, we can then also stick with the dashboard name and URI.

@joewiz
Copy link
Member Author

joewiz commented Jan 21, 2019

I prefer the original URL too. Not a showstopper for inclusion in the RC though?

@adamretter
Copy link
Contributor

@joewiz I think for me it is a showstopper.

Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should fix #2200 first,
i agree with @adamretter that the URL changes should be fixed before inclusion in the RC

@joewiz joewiz closed this Jan 21, 2019
@joewiz
Copy link
Member Author

joewiz commented Jan 21, 2019

Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features, suggestions, etc. needs 5.x.x backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants