Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The content of comments should not be escaped #2739

Merged
merged 1 commit into from
May 26, 2019
Merged

The content of comments should not be escaped #2739

merged 1 commit into from
May 26, 2019

Conversation

adamretter
Copy link
Contributor

Closes #2728

@adamretter adamretter added the bug issue confirmed as bug label May 24, 2019
@adamretter adamretter added this to the eXist-4.7.1 milestone May 24, 2019
@adamretter adamretter requested a review from a team May 24, 2019 21:01
@adamretter adamretter modified the milestones: eXist-4.7.1, eXist-5.0.0 May 24, 2019
@adamretter adamretter mentioned this pull request May 24, 2019
Merged
duncdrum
duncdrum approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see eXist-db/dashboard#88

@adamretter
Copy link
Contributor Author

adamretter commented May 25, 2019 •
edited
Loading

@duncdrum the problem with eXist-db/dashboard#88 is that the XML Specification says that you cannot have -- inside a comment.

@duncdrum
Copy link
Contributor

@adamretter and in joerns build he escaped the — inside a comment which somehow gets expanded into an not well-formed xml inside exist

@duncdrum duncdrum merged commit f6e007f into eXist-db:develop May 26, 2019
@dizzzz
Copy link
Member

dizzzz commented May 26, 2019

isn't there a 4.x port needed?

@adamretter
Copy link
Contributor Author

@dizzzz I understood from last-weeks community call that 4.7.0 was meant to be the last in 4.x.x line?

@dizzzz
Copy link
Member

dizzzz commented May 26, 2019

make sense.... but maybe some bug fixes when it is really needed? (eg patch it in codebase so at least ppl can use it?)

@adamretter adamretter deleted the hotfix/comment-escaping branch March 20, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

Assignees
No one assigned
Labels
bug issue confirmed as bug
Projects
None yet
Milestone
eXist-5.1.0
Development

Successfully merging this pull request may close these issues.

comment nodes incorrectly unescaped?
3 participants
@adamretter @duncdrum @dizzzz