[bugfix] Fix ignored namespace binding conflict #4507
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
dizzzz
requested changes
Jul 28, 2022
line-o
reviewed
Jul 28, 2022
adamretter
suggested changes
Aug 3, 2022
There was a problem hiding this comment.
I have just attempted the test in the linked issue. Unfortunately it shows that this is not the correct solution to the problem. We cannot statically detect this at compile time as this PR attempts to do, the issue we are trying to solve can only be detected at runtime.
|
Can we close this PR, @adamretter? The linked issue is closed. |
duncdrum
added
the
awaiting-response
|
As this is not the right fix, and there are pending change request I’ll convert this to draft |
adamretter
force-pushed
the
bugfix/namespace-binding-conflict
branch
from
e906b1e
to
4231785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add error when namespace binding conflict occurs.
Reference:
#1482
Type of tests:
Existing tests still work.
This open source contribution to the eXist-db project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.