Fix namespace binding conflict errors with XQuery Update #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpaxton
force-pushed
the
feature/xquery-update-30,binding-conflict-error
branch
from
8d7bf04 to
498b188
Compare
@see eXist-db#1482 Report an error (XUDY0023) when an insertion is attempted with a node or attribute name in a namespace that conflicts with one which exists in the document. @see https://www.w3.org/TR/xquery-update-30/#dt-conflict Check node/attributes inserted recursively. This change does not look at namespaces introduced in the subtrees being inserted, so there is still potential for a conflict in the final tree. We will consider rejecting conflicting namespaces introduced in the insertion in a later change.
alanpaxton
force-pushed
the
feature/xquery-update-30,binding-conflict-error
branch
from
498b188 to
441feab
Compare
|
Kudos, SonarCloud Quality Gate passed! |
adamretter
changed the title
adamretter
deleted the
feature/xquery-update-30,binding-conflict-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Report an error (
XUDY0023) when an insertion is attempted with a node or attribute name in a namespace that conflicts with one which exists in the document.References:
Closes #1482
See https://www.w3.org/TR/xquery-update-30/#dt-conflict
Recursively check node/attributes inserted into a document for namespace conflicts. This change does not look at namespaces introduced in the subtrees being inserted, it appears these correctly respect the namespace in the subtree rather than the declared namespace in the XQuery context in which the insertion happens.
Type of tests:
Added unit tests in
binidingConflict.xqmfor correct reporting of binding conflict errors