Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] allow filtering of templating specific data attributes from output #15

Merged
merged 5 commits into from
Nov 16, 2022
Merged

[enhancement] allow filtering of templating specific data attributes from output #15

merged 5 commits into from
Nov 16, 2022

Conversation

line-o
Copy link
Member

@line-o line-o commented Nov 11, 2022 •
edited
Loading

Setting $templates:CONFIG_FILTER_ATTRIBUTES to true in the
configuration map will filter templating specific data attributes from
the output.
The setting is off by default to keep backwards compatibility.

Add working XQSuite tests to ensure this works.

Example:

Default output:

<html>
    <body data-template="tt:tf" class="body" data-extra="7">2
        <ul>
            <li data-template="templates:each" data-template-from="data" data-template-to="item" data-extra="23" class="item">
                <span data-template="tt:n" data-extra="42" class="value">1</span>
            </li>
            <li data-template="templates:each" data-template-from="data" data-template-to="item" data-extra="23" class="item">
                <span data-template="tt:n" data-extra="42" class="value">3</span>
            </li>
        </ul>
    </body>
</html>

With filtered attributes:

<html>
    <body class="body" data-extra="7">2
        <ul>
            <li data-extra="23" class="item">
                <span data-extra="42" class="value">1</span>
            </li>
            <li data-extra="23" class="item">
                <span data-extra="42" class="value">3</span>
            </li>
        </ul>
    </body>
</html>

@line-o
feat: allow filtering of attributes from output
01909da 
Setting `$templates:CONFIG_FILTER_ATTRIBUTES` to true in the
configuration map will filter templating specific data attributes from
the output.
The setting is off by default to keep backwards compatibility.
Add working XQSuite tests to ensure this works.
@line-o line-o mentioned this pull request Nov 11, 2022
Merged
@line-o
chore: fix tests in v5.2.0
ffdf1cb
@line-o
test: include XQSuite test in npm test
f3316f9 
- copy test-runner and test-suite to build
- fix test-runner and xqSuite
- add xqSuite.js run to test script
@line-o
test: refactor rest_spec.js
730a8c1 
- split up tests into set up and several more granular assertions
@line-o
test: ensure other attributes are not affected
1557f78
duncdrum
duncdrum approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, and does what it promises

@duncdrum duncdrum merged commit 35f3136 into eXist-db:master Nov 16, 2022
@line-o line-o deleted the feat/filter-attr branch November 20, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

@wolfgangmm wolfgangmm Awaiting requested review from wolfgangmm

@joewiz joewiz Awaiting requested review from joewiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@line-o @duncdrum