Try using info() instead of type(). #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, now it uses |
|
Don't pull this yet. We could still fall back to |
Fall back to using `type()` if `info()` doesn't work for some reason. For example if the identifier is ambiguous or we aren't top-level.
|
This works well I think. The only two remaining issues I see are that the "modified buffer" error prints twice due to the two calls, and that we could try to resolve the ambiguity problem by calling |
eagletmt
added a commit
that referenced
this pull request
Sep 26, 2012
Try using info() instead of type().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to say if this is a better approach or not, but at least it does the typeclass constraints properly.