patch(vest): isValid uses static summary

ealush · Mar 28, 2022 · 6446c19 · 6446c19
1 parent a8484a8
commit 6446c19
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/vest/src/core/suite/produce/genTestsSummary.ts b/packages/vest/src/core/suite/produce/genTestsSummary.ts
@@ -2,7 +2,7 @@ import assign from 'assign';
 
 import { Severity, SeverityCount } from 'Severity';
 import VestTest from 'VestTest';
-import { isValid } from 'isValid';
+import { shouldAddValidProp } from 'isValid';
 import { useTestsFlat } from 'stateHooks';
 
 /**
@@ -26,7 +26,7 @@ export default function genTestsSummary(): SuiteSummary {
     summary
   );
 
-  summary.valid = isValid();
+  summary.valid = shouldAddValidProp();
 
   return countFailures(summary);
 }
@@ -37,7 +37,7 @@ function appendToTest(tests: TestGroup, testObject: VestTest) {
   tests[testObject.fieldName].valid =
     tests[testObject.fieldName].valid === false
       ? false
-      : isValid(testObject.fieldName);
+      : shouldAddValidProp(testObject.fieldName);
 }
 
 /**

diff --git a/packages/vest/src/core/suite/produce/isValid.ts b/packages/vest/src/core/suite/produce/isValid.ts
@@ -1,5 +1,7 @@
+import invariant from 'invariant';
 import { isNotEmpty, isEmpty } from 'isEmpty';
 
+import ctx from 'ctx';
 import { hasErrors } from 'hasFailures';
 import { nonMatchingFieldName } from 'matchingFieldName';
 import {
@@ -9,8 +11,16 @@ import {
   useOmittedFields,
 } from 'stateHooks';
 
-// eslint-disable-next-line max-statements, complexity
 export function isValid(fieldName?: string): boolean {
+  const { summary } = ctx.useX();
+
+  invariant(summary);
+
+  return Boolean(fieldName ? summary.tests?.[fieldName]?.valid : summary.valid);
+}
+
+// eslint-disable-next-line max-statements, complexity
+export function shouldAddValidProp(fieldName?: string): boolean {
   if (fieldIsOmitted(fieldName)) {
     return true;
   }