-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
…g#61) Exposes a config in storage config section to allow setting http headers to the default http client. This is because some of the underlying storage systems (e.g. s3 stow) doesn't allow setting some settings (e.g. ACL) and the only way to support that is through setting HTTP HEADERS that AWS S3 respects.
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package storage | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/lyft/flytestdlib/config" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func Test_createHTTPClient(t *testing.T) { | ||
| t.Run("empty", func(t *testing.T) { | ||
| client := createHTTPClient(HTTPClientConfig{}) | ||
| assert.Nil(t, client.Transport) | ||
| }) | ||
|
|
||
| t.Run("Some headers", func(t *testing.T) { | ||
| m := map[string][]string{ | ||
| "Header1": {"val1", "val2"}, | ||
| } | ||
|
|
||
| client := createHTTPClient(HTTPClientConfig{ | ||
| Headers: m, | ||
| }) | ||
|
|
||
| assert.NotNil(t, client.Transport) | ||
| proxyTransport, casted := client.Transport.(*proxyTransport) | ||
| assert.True(t, casted) | ||
| assert.Equal(t, m, proxyTransport.defaultHeaders) | ||
| }) | ||
|
|
||
| t.Run("Set empty timeout", func(t *testing.T) { | ||
| client := createHTTPClient(HTTPClientConfig{ | ||
| Timeout: config.Duration{}, | ||
| }) | ||
|
|
||
| assert.Zero(t, client.Timeout) | ||
| }) | ||
|
|
||
| t.Run("Set timeout", func(t *testing.T) { | ||
| client := createHTTPClient(HTTPClientConfig{ | ||
| Timeout: config.Duration{Duration: 2 * time.Second}, | ||
| }) | ||
|
|
||
| assert.Equal(t, 2*time.Second, client.Timeout) | ||
| }) | ||
| } | ||
|
|
||
| func Test_applyDefaultHeaders(t *testing.T) { | ||
| input := map[string][]string{ | ||
| "Header1": {"val1", "val2"}, | ||
| } | ||
|
|
||
| r := &http.Request{} | ||
| applyDefaultHeaders(r, input) | ||
|
|
||
| assert.Equal(t, http.Header(input), r.Header) | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.