Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one change #28

Open
wants to merge 1 commit into
base: tabs-test
Choose a base branch
from
Open

one change #28

wants to merge 1 commit into from

Conversation

earlAchromatic
Copy link
Owner

@earlAchromatic earlAchromatic commented Sep 17, 2022 •
edited
Loading

This change is Reviewable

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 9, 2023

reply

@earlAchromatic
Copy link
Owner Author

sure

prcl8tr
prcl8tr reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@prcl8tr prcl8tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @earlAchromatic)

.eleventy.js line 43 at r1 (raw file):

function transformContent(content) {
  let dom = new JSDOM(content);
  let doc = dom.window.document;

discussing

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

  let dom = new JSDOM(content);

  return dom.serialize();

inform

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 9, 2023

.eleventy.js line 44 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

inform

discussi

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 42 at r1 (raw file):

function transformContent(content) {
  let dom = new JSDOM(content);

sfds

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 42 at r1 (raw file):

function transformContent(content) {
  let dom = new JSDOM(content);

block

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

Previously, prcl8tr wrote…

discussi

Yes

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 43 at r1 (raw file):

Previously, prcl8tr wrote…

discussing

replying

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 9, 2023

.eleventy.js line 42 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sfds

Yes

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 42 at r1 (raw file):

Previously, prcl8tr wrote…

Yes

reply

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 10, 2023

.eleventy.js line 42 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

reply

reply reply

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 42 at r1 (raw file):

Previously, prcl8tr wrote…

reply reply

reply reply reply

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 10, 2023

.eleventy.js line 42 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

reply reply reply

dismissal

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 10, 2023

.eleventy.js line 43 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

replying

dismissal 2

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 10, 2023

.eleventy.js line 44 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

Yes

info

@prcl8tr
Copy link
Collaborator

prcl8tr commented Mar 10, 2023

.eleventy.js line 44 at r1 (raw file):

Previously, prcl8tr wrote…

info

cancel dismissal

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 43 at r1 (raw file):

Previously, prcl8tr wrote…

dismissal 2

s

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 43 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

s

sd

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

Previously, prcl8tr wrote…

cancel dismissal

fs

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

fs

sdf

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 42 at r1 (raw file):

Previously, prcl8tr wrote…

dismissal

resolve

@earlAchromatic
Copy link
Owner Author

@oscl8tr

@earlAchromatic earlAchromatic changed the base branch from main to is-this-for-real March 31, 2023 00:21
@earlAchromatic earlAchromatic changed the base branch from is-this-for-real to really-long-test-name-branch-name March 31, 2023 00:21
@earlAchromatic earlAchromatic changed the base branch from really-long-test-name-branch-name to dev March 31, 2023 00:21
@earlAchromatic earlAchromatic changed the base branch from dev to col-test March 31, 2023 00:22
@earlAchromatic earlAchromatic changed the base branch from col-test to overlap-test March 31, 2023 00:22
@earlAchromatic earlAchromatic changed the base branch from overlap-test to protected March 31, 2023 00:22
@earlAchromatic earlAchromatic changed the base branch from protected to revert-24-revert-23-revert-22-revert-21-revert-20-revert-19-revert-18-revert-17-col-test March 31, 2023 00:22
@earlAchromatic earlAchromatic changed the base branch from revert-24-revert-23-revert-22-revert-21-revert-20-revert-19-revert-18-revert-17-col-test to tabs-test March 31, 2023 00:23
@earlAchromatic
Copy link
Owner Author

yup

@oscl8tr
Copy link
Collaborator

oscl8tr commented Apr 1, 2023

Previously, earlAchromatic (Jacob Milhorn) wrote…

yup

yip up

@oscl8tr
Copy link
Collaborator

oscl8tr commented Apr 1, 2023

Previously, oscl8tr wrote…

yip up

yip yui[ yap

@earlAchromatic
Copy link
Owner Author

Previously, oscl8tr wrote…

yip yui[ yap

ok

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 50 at r1 (raw file):

  for (const [key, value] of Object.entries(componentRegistry)) {
    let registeredComponent = key;
    let registeredComponentPath = value;

so

@earlAchromatic
Copy link
Owner Author

-- commits line 1 at r1:
dicussing

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 41 at r1 (raw file):

};

function transformContent(content) {

sf

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

  let dom = new JSDOM(content);
  let doc = dom.window.document;

jf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Apr 1, 2023

.eleventy.js line 44 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

jf

sfsdfg

@oscl8tr
Copy link
Collaborator

oscl8tr commented Apr 1, 2023

.eleventy.js line 50 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

so

sfd

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 44 at r1 (raw file):

Previously, oscl8tr wrote…

sfsdfg

hoep

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 50 at r1 (raw file):

Previously, oscl8tr wrote…

sfd

jsfj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prcl8tr prcl8tr prcl8tr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@earlAchromatic @prcl8tr @oscl8tr