Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test branch #7

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

New test branch #7

wants to merge 16 commits into from

Conversation

earlAchromatic
Copy link
Owner

@earlAchromatic earlAchromatic commented Jul 26, 2022

This change is Reviewable

Copy link
Owner Author

@earlAchromatic earlAchromatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdf

Reviewed 1 of 14 files at r1.
Reviewable status: 1 of 14 files reviewed, 3 unresolved discussions


.eleventy.js line 11 at r1 (raw file):

const componentRegistry = {
  myHeader: '../components/myHeader.vue',

dsf


.eleventy.js line 24 at r1 (raw file):

  return {
    dir: {
      input: 'src',

sdf


.eleventy.js line 24 at r1 (raw file):

      // Read more below
      console.log(results[0].content);
      results.forEach((result) => {

dsf

Copy link
Owner Author

@earlAchromatic earlAchromatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadfdsf

Reviewed 13 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions

@earlAchromatic earlAchromatic added the enhancement New feature or request label Aug 3, 2022
@earlAchromatic
Copy link
Owner Author

.eleventy.js line 11 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dsf

Suggestion:

  myHeader: '../components/myH eader.vue',

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 19 at r2 (raw file):

  eleventyConfig.addPassthroughCopy({ public: '/' }); eleventyConfig.addPassthroughCopy('components');eleventyConfig.addPassthroughCopy('node_modules');eleventyConfig.on('eleventy.after',
    async ({ dir, results, runMode, outputMode }) => {
      // Read more below

sdf

@earlAchromatic
Copy link
Owner Author

does this message add a header?

@earlAchromatic
Copy link
Owner Author

Does this ?

@earlAchromatic
Copy link
Owner Author

how about this response?

@earlAchromatic
Copy link
Owner Author

Does this message add a no related file header?

@earlAchromatic
Copy link
Owner Author

.eleventy.js line 0 at r2 (raw file):
adsf

Code snippet:

;kll;;kl

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/Loading.vue line 3 at r2 (raw file):

<template>
  <div>:()</div>
</template>

sdf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/Loading.vue line 3 at r2 (raw file):

<template>
  <div>:()</div>
</template>

asdf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

sf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

das

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

ag

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 29, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

sdf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 30, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

sdf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 30, 2024

components/Loading.vue line 3 at r2 (raw file):

<template>
  <div>:()</div>
</template>

asdf

@oscl8tr
Copy link
Collaborator

oscl8tr commented Mar 30, 2024

components/SlottedComp.vue line 4 at r2 (raw file):

  <h2>Slot here</h2>
  <slot>steady does it champo</slot>
</template>

sadf

@earlAchromatic
Copy link
Owner Author

.eleventy.js line at r2 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

adsf

:lgtm:

Copy link
Owner Author

@earlAchromatic earlAchromatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 14 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 15 unresolved discussions (waiting on @oscl8tr)

a discussion (no related file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

does this message add a header?

another comment



.eleventy.js line 11 at r1 (raw file):

const componentRegistry = {
  myHeader: '../components/myHeader.vue',

Working


.eleventy.js line 15 at r1 (raw file):

module.exports = function (eleventyConfig) {
  eleventyConfig.addPassthroughCopy({ public: '/' });

BTW

Code quote (i):

  eleventyConfig.addPassthroughCopy({ public: '/' });

Code quote (ii):

  eleventyConfig.addPassthroughCopy({ public: '/' }); eleventyConfig.addPassthroughCopy('components');eleventyConfig.addPassthroughCopy('node_modules');eleventyConfig.on('eleventy.after',

.eleventy.js line 24 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sdf

sdf


.eleventy.js line 24 at r1 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

dsf

sdf

Code quote:

      results.forEach((result) => {

.eleventy.js line 29 at r1 (raw file):

};

function transformContent(content) {

s

Code quote (i):

function transformContent(content) {

Code quote (ii):

function transformContent(content) {

.eleventy.js line 11 at r2 (raw file):

const componentRegistry = {
  myHeader: '../components/myHeader.vue',
  myFooter: '../components/myFooter.vue',

sf

:lgtm:

Code quote:

const util = require('futil');

.eleventy.js line 19 at r2 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…

sdf

Working.


.eleventy.js line 34 at r2 (raw file):

  eleventyConfig.addPlugin(EleventyVitePlugin, {
    tempFolderName: '.11ty-vite', // Default name of the temp folder

asdf

Code quote:

    tempFolderName: '.11ty-vite', // Default name of the temp folder

.eleventy.js line 79 at r2 (raw file):

    el.setAttribute('injectionPoint', true);
    el.innerHTML = VueWrapper;
    comp.replaceWith(el);

Nit.


.eleventy.js line at r2 (raw file):

Previously, earlAchromatic (Jacob Milhorn) wrote…
:lgtm:

:lgtm:

___ *[`package-lock.json` line 146 at r2](http://localhost:8080/reviews/earlachromatic/11ty-vue-pragmatic-components/7#-NBwka-Y6hJV8P3iIxMA:-N92ugtL-gbYWDR9XtfE:b-x6jyri) ([raw file](https://github.com/earlachromatic/11ty-vue-pragmatic-components/blob/17318a65e445456fec296c6eef956e03b0f28740/package-lock.json#L146)):* > ```JSON > }, > "sass": { > "optional": true > ```

Working.


package-lock.json line 955 at r2 (raw file):

      },
      "engines": {
        "node": ">=12"

package-lock.json line 3446 at r2 (raw file):

          "version": "2.9.14",
          "resolved": "https://registry.npmjs.org/vite/-/vite-2.9.14.tgz",
          "integrity": "sha512-P/UCjSpSMcE54r4mPak55hWAZPlyfS369svib/gpmz8/01L822lMPOJ/RYW6tLCe1RPvMvOsJ17erf55bKp4Hw==",

package-lock.json line 4090 at r2 (raw file):

        "esbuild-sunos-64": "0.14.50",
        "esbuild-windows-32": "0.14.50",
        "esbuild-windows-64": "0.14.50",

sdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants