Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seeed xiao rp2350 board #2533

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add seeed xiao rp2350 board #2533

merged 1 commit into from
Oct 11, 2024

Conversation

Cincinnatu
Copy link
Contributor

No description provided.

earlephilhower
earlephilhower requested changes Oct 10, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the updated makeboards? That needs to be checked in.

@Cincinnatu
Copy link
Contributor Author

Where is the updated makeboards? That needs to be checked in.
This is the link to the Seeed Xiao RP2350 board that I added recently: https://www.seeedstudio.com/Seeed-XIAO-RP2350-p-5944.html. Do you need us to provide any other information?

@earlephilhower
Copy link
Owner

No, what you need to check in is tools/makeboards.py which (I hope) you added the new board to. If you just cut-n-paste or edited boards.txt in any way that's not going to work. You need to update makeboards.py, rerun it, and check in the new script and files. See the docs for more info.

@Cincinnatu Cincinnatu force-pushed the master branch 4 times, most recently from df04909 to a3cfe36 Compare October 11, 2024 04:36
earlephilhower
earlephilhower approved these changes Oct 11, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks

@earlephilhower earlephilhower merged commit 49f83c4 into earlephilhower:master Oct 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cincinnatu @earlephilhower