Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/single precision #171

Conversation

climbfuji
Copy link
Contributor

WORK IN PROGRESS

  • Switch working precision to single precision of preprocessor flag -DSINGLE_PRECISION is set

@RobertPincus
Copy link
Member

RobertPincus commented May 22, 2022

@climbfuji Note the same functionality is already on the develop branch in commit 345aefb.

I like to move things from develop to main and then out to autoconf and ccpp. If this is pressing please let me know and I'll update main.

Note also that this won't work - some calculations will fail if done in single precision. This is something we're working on and can prioritize if you have an immediate need.

@climbfuji
Copy link
Contributor Author

climbfuji commented May 22, 2022

@climbfuji Note the same functionality is already on the develop branch in commit 345aefb.

I like to move things from develop to main and then out to autoconf and ccpp. If this is pressing please let me know and I'll update main.

Note also that this won't work - some calculations will fail if done in single precision. This is something we're working on and can prioritize if you have an immediate need.

@RobertPincus Absolutely agree. You'll be receiving an email in a second that provides more background.

@Chiil
Copy link
Collaborator

Chiil commented May 22, 2022

Would it be a good idea to add a prefix RTE_RRTMGP_ or something similar to preprocessor flags?

@RobertPincus
Copy link
Member

Closed with a4fe30c but note that code compiled as single precision almost certainly won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants