Extend Levante CI with NAG #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skosukhin Thanks, this is great. I agree on the limiting of the test suite. For me the main advantage of NAG is that it's quite picky about compilation questions (it nags me). It's more valuable to have it cover both accel and default kernels than worry about DP/SP. |
skosukhin
force-pushed
the
levante-ci-nag
branch
from
ead407a to
6e1bfc6
Compare
|
I'd also like to understand the runtime error produced in the accel kernels. |
RobertPincus
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CI tests with the NAG compiler on Levante.
The compiler version and flags are what we currently use to build ICON by default.
Two of the four added tests currently fail and, therefore, are marked as
experimental.I also think that four is too many and we should keep only two. For example, I would keep
nag-cpu-default-SP(single-precision, default kernels) andnag-cpu-accel-DP(double-precision, accel kernels).