Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel ice sizes as diameter #311

Closed
wants to merge 1 commit into from

Conversation

RobertPincus
Copy link
Member

Tables in the RRTMGP data, and code here, suggested that liquid and ice cloud optical properties were tabulated as a function of radius; in fact ice clouds are tabulated vs. diameter.

Addresses #309

@RobertPincus RobertPincus requested a review from Chiil December 13, 2024 03:02
Copy link
Collaborator

@Chiil Chiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. Should there be a test added for this? There is no change anywhere that corrects radius to diameter.

@RobertPincus
Copy link
Member Author

@Chiil The names of the axes for ice cloud size is changed to diam

@RobertPincus
Copy link
Member Author

Superseded by #342

@RobertPincus RobertPincus deleted the hotfix-relabel-ice-sizes branch January 14, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants