Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panorama dygraph not aligning correctly #14

Closed
earthgecko opened this issue Jul 29, 2016 · 1 comment
Closed

Panorama dygraph not aligning correctly #14

earthgecko opened this issue Jul 29, 2016 · 1 comment

Comments

@earthgecko
Copy link
Owner

Panorama dygraph not aligning correctly which is caused by the Panorama
timeshift and the user time zone.

The timeshift was not proportional in terms of multiple full_duration
possibilities. It was using / 24, a hard code in calculation of the Graphite
data retrieval parameters from the old skyline.js that was used to pattern
panorama.js with.

Time zone - the dygraphs graphs are compiled in the users tz, not the timeseries
tz. And this has always been a problem, just near really seen as the original
Skyline UI was only probably looking at last 24 hours of Redia data so never
really a problem as no timeshifting and if your Skyline server was in a
different timezone from your browser this would have applied.
earthgecko added a commit that referenced this issue Jul 29, 2016
@earthgecko
v1.0.2-beta-crucible - crucible
e7a41a9 
- Using Eddified's elegent hack to overwrite Dygraph's DateAccessorsUTC to
  return values according to the currently selected timezone as per:
  http://stackoverflow.com/a/24196184 to fix
  Issue #14 - Panorama dygraph not aligning correctly (interal ref bug1524)
  #14
- Add the WEBAPP timezone related variables to settings.py
- Added moment.js/2.14.1 and moment-timezone/0.5.5 to be pulled from
  cdnjs.cloudflare.com
- Added time zone section to Webapp docs
- Added rebrow flask.flash messages and confirmation on deleting a Redis key
- Fixed type error in a skyline_functions.py except
- Bumped up to version 1.0.2

Added:
docs/releases/1_0_2.rst

Modified:
docs/conf.py
docs/installation.rst
docs/releases.rst
docs/webapp.rst
docs/whats-new.md
skyline/settings.py
skyline/skyline_functions.py
skyline/skyline_version.py
skyline/webapp/static/js/panorama.js
skyline/webapp/templates/layout.html
skyline/webapp/templates/panorama.html
skyline/webapp/templates/rebrow_keys.html
skyline/webapp/webapp.py
earthgecko added a commit that referenced this issue Jul 29, 2016
@earthgecko
v1.0.2-beta-crucible - master
ed127ea 
- Using Eddified's elegent hack to overwrite Dygraph's DateAccessorsUTC to
  return values according to the currently selected timezone as per:
  http://stackoverflow.com/a/24196184 to fix
  Issue #14 - Panorama dygraph not aligning correctly (interal ref bug1524)
  #14
- Add the WEBAPP timezone related variables to settings.py
- Added moment.js/2.14.1 and moment-timezone/0.5.5 to be pulled from
  cdnjs.cloudflare.com
- Added time zone section to Webapp docs
- Added rebrow flask.flash messages and confirmation on deleting a Redis key
- Fixed type error in a skyline_functions.py except
- Bumped up to version 1.0.2

Added:
docs/releases/1_0_2.rst

Modified:
docs/conf.py
docs/installation.rst
docs/releases.rst
docs/webapp.rst
docs/whats-new.md
skyline/settings.py
skyline/skyline_functions.py
skyline/skyline_version.py
skyline/webapp/static/js/panorama.js
skyline/webapp/templates/layout.html
skyline/webapp/templates/panorama.html
skyline/webapp/templates/rebrow_keys.html
skyline/webapp/webapp.py
@earthgecko
Copy link
Owner Author

v1.0.2-beta-crucible fixes this.

@earthgecko earthgecko mentioned this issue Aug 1, 2016
Open
earthgecko added a commit that referenced this issue Jan 4, 2017
@earthgecko
Panorama check file fails #24 - v1.1.0-alpha
1604bfd 
IssueID #1830: Ionosphere alerts
IssueID #1460: panorama check file fails

- Removed the buggy skyline_functions.load_metric_vars and replaced with the
  new_load_metric_vars(self, metric_vars_file) function
- Fixes #14

Modified:
skyline/panorama/panorama.py
earthgecko added a commit that referenced this issue Jan 4, 2017
@earthgecko
Panorama check file fails #24 - v1.1.0-alpha
b1fd994 
IssueID #1830: Ionosphere alerts
IssueID #1460: panorama check file fails

- Removed the buggy skyline_functions.load_metric_vars and replaced with the
  new_load_metric_vars(self, metric_vars_file) function
- Fixes #14
- Changed ionosphere_backend.py to the new function

Modified:
skyline/panorama/panorama.py
skyline/webapp/ionosphere_backend.py
earthgecko added a commit that referenced this issue Jan 7, 2017
@earthgecko
Ionosphere - Graphite now graphs - v1.1.0-alpha
72d04da 
IssueID #1842: Ionosphere - Graphite now graphs
IssueID #1658: Patterning Skyline Ionosphere
IssueID #1460: panorama check file fails
Panorama check file fails #24

- Added returns to skyline_functions.get_graphite_metric and specific webapp
  Ionosphere URL parameters for the Graphite NOW graphs
- Removed unused get_graphite_metric from skyline/webapp/backend.py
- Added get_graphite_metric, the graphite_now png context and retrieving the
  graphite_now_images at TARGET_HOURS, 24h, 7d and 30d
- Removed the reference to #14 from webapp Ionosphere templates
- Added order and graphite_now_images block to training_data.html
- Added sorted_images for order and graphite_now_images to webapp

Modified:
skyline/skyline_functions.py
skyline/webapp/backend.py
skyline/webapp/ionosphere_backend.py
skyline/webapp/templates/features_profiles.html
skyline/webapp/templates/training_data.html
skyline/webapp/webapp.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@earthgecko