Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional exception handling to Analyzer #19

Closed
earthgecko opened this issue Aug 1, 2016 · 1 comment
Closed

Add additional exception handling to Analyzer #19

earthgecko opened this issue Aug 1, 2016 · 1 comment

Comments

@earthgecko
Copy link
Owner

There has been a new report of Analyzer stalling and nothing in the log.

All the extension and modifications of Analyzer in previous changes did not add except methods to anything that did not have one. All new additions to Skyline have used much more except methods.

except methods to be added to Analyzer wherever required in a manner suitable to Analyzer in terms of not vomiting into the log, but doing things more gracefully.
earthgecko added a commit that referenced this issue Aug 3, 2016
@earthgecko
v1.0.4-crucible-beta to crucible
177e4b1 
- Corrected boundary anomaly_seen log info context

Modified:
skyline/boundary/boundary.py

- In the skyline_functions get_graphite_metric slip the fetching Graphite json
  into 2 try: blocks the actual Graphite request and the reading datapoints from
  json and added the graphite_json_fetched variable to test the condition
- Padded out skyline_functions docstrings with type definitions for each param
- Escape : ( and ) in metric name to Graphite URI for Unescaped Graphite target
  #20 in mirage and skyline_functions
- Rmoved old sys.path requirements for the old import settings method.

Modified:
skyline/skyline_functions.py
skyline/mirage/mirage.py

- Added some notes to the development doc regarding ongoing refactoring work

Modified:
docs/development/index.rst

- Added validation on all Panorama GET parameters to mitigate as much XSS and
  SQL injection as I can at the moment, arachni is happier now.
- Sanitize request.args

Modified:
skyline/webapp/backend.py
skyline/webapp/webapp.py
docs/webapp.rst

- Added missing settings. to CRUCIBLE_PROCESSES thanks @blake3r2, this stops it
  doing nothing.  This branch reallt should have been called panorama, but it
  started last year as crucible, so crucible was not fully tested in the new
  structure, apologies.

Modified:
skyline/crucible/crucible.py

- Misc docs changes

Modified:
docs/mirage.rst
docs/requirements.rst
docs/upgrading.rst
docs/installation.rst

- Adding additional exception handling to Analyzer - Issue #19 - task1544
  #19
- This is a start but not complete, other issues took precedence and these are
  the changes to date.

Modified:
skyline/analyzer/analyzer.py

- Bumped version to 1.0.4

Added:
docs/releases/1_0_4.rst
Modified:
docs/conf.py
skyline/skyline_version.py
docs/releases.rst
earthgecko added a commit that referenced this issue Aug 3, 2016
@earthgecko
v1.0.4-crucible-beta to master
6e51d81 
- Corrected boundary anomaly_seen log info context

Modified:
skyline/boundary/boundary.py

- In the skyline_functions get_graphite_metric slip the fetching Graphite json
  into 2 try: blocks the actual Graphite request and the reading datapoints from
  json and added the graphite_json_fetched variable to test the condition
- Padded out skyline_functions docstrings with type definitions for each param
- Escape : ( and ) in metric name to Graphite URI for Unescaped Graphite target
  #20 in mirage and skyline_functions
- Rmoved old sys.path requirements for the old import settings method.

Modified:
skyline/skyline_functions.py
skyline/mirage/mirage.py

- Added some notes to the development doc regarding ongoing refactoring work

Modified:
docs/development/index.rst

- Added validation on all Panorama GET parameters to mitigate as much XSS and
  SQL injection as I can at the moment, arachni is happier now.
- Sanitize request.args

Modified:
skyline/webapp/backend.py
skyline/webapp/webapp.py
docs/webapp.rst

- Added missing settings. to CRUCIBLE_PROCESSES thanks @blake3r2, this stops it
  doing nothing.  This branch reallt should have been called panorama, but it
  started last year as crucible, so crucible was not fully tested in the new
  structure, apologies.

Modified:
skyline/crucible/crucible.py

- Misc docs changes

Modified:
docs/mirage.rst
docs/requirements.rst
docs/upgrading.rst
docs/installation.rst

- Adding additional exception handling to Analyzer - Issue #19 - task1544
  #19
- This is a start but not complete, other issues took precedence and these are
  the changes to date.

Modified:
skyline/analyzer/analyzer.py

- Bumped version to 1.0.4

Added:
docs/releases/1_0_4.rst
Modified:
docs/conf.py
skyline/skyline_version.py
docs/releases.rst
@earthgecko
Copy link
Owner Author

Some of this should now be handled in v1.0.4-crucible-beta. Not complete.

earthgecko added a commit that referenced this issue Aug 18, 2016
@earthgecko
Issue #19: Add additional exception handling to Analyzer
1100362 
Wrapped the surfacing of the self.anomalous_metrics list and the writing of the
anomalies.json in some excepts

Modified:
skyline/analyzer/analyzer.py
earthgecko added a commit that referenced this issue Aug 18, 2016
@earthgecko
Issue #19: Add additional exception handling to Analyzer
e0350b6 
Wrapped the surfacing of the self.anomalous_metrics list and the writing of the
anomalies.json in some excepts

Modified:
skyline/analyzer/analyzer.py
earthgecko added a commit that referenced this issue Aug 18, 2016
@earthgecko
Issue #19: Add additional exception handling to Analyzer
b4aa7f6 
Added traceback if issue writing of the anomalies.json file

Modified:
skyline/analyzer/analyzer.py
earthgecko added a commit that referenced this issue Aug 18, 2016
@earthgecko
Issue #19: Add additional exception handling to Analyzer
75e124e 
Added traceback if issue writing of the anomalies.json file

Modified:
skyline/analyzer/analyzer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@earthgecko