Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx to 4.0.2 #410

Closed
wants to merge 5 commits into from
Closed

Conversation

pyup-bot
Copy link
Collaborator

This PR updates sphinx from 4.0.1 to 4.0.2.

Changelog

4.0.2

=====================================

Dependencies
------------

* 9216: Support jinja2-3.0

Incompatible changes
--------------------

* 9222: Update Underscore.js to 1.13.1
* 9217: manpage: Stop creating a section directory on build manpage by default
(see :confval:`man_make_section_directory`)

Bugs fixed
----------

* 9210: viewcode: crashed if non importable modules found on parallel build
* 9240: Unknown node error for pending_xref_condition is raised if an extension
that does not support the node installs a missing-reference handler
Links

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #410 (79f4186) into main (22024e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   50.44%   50.44%           
=======================================
  Files          22       22           
  Lines        1447     1447           
=======================================
  Hits          730      730           
  Misses        717      717           
Flag Coverage Δ
unittests 50.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22024e1...79f4186. Read the comment docs.

@nkorinek
Copy link
Member

@lwasser so I did some trouble shooting here. It seems that the update of sphinx changed the jinja2 dependency to be 3.0.1. Something in the jinja2 update is causing our custom html theme pydata_sphinx_theme to fail in the readthedocs build. I changed the theme to classic and now it passes all checks. The other solution would be to put jinja2 in the dependencies as an earlier version but doesn't seem like a long term solution. Let me know your thoughts!

@lwasser
Copy link

lwasser commented Sep 14, 2021

hey @nkorinek i totally see - i opened issue #439 ... the point of failure happened with the update to sphinx 4.x. i'm curious what happens if we update things if it will fix bugs now?

@lwasser
Copy link

lwasser commented Sep 14, 2021

@nkorinek i have fixed the build. i am going to close this issue now given others have been merged with updated versions! thank you for looking into this.

@lwasser lwasser closed this Sep 14, 2021
@nkorinek
Copy link
Member

nkorinek commented Sep 14, 2021

wow, nice! Glad you figured it out so quick @lwasser

@lwasser
Copy link

lwasser commented Sep 14, 2021

well @nkorinek those smarter than myself figured it out and pushed an update to the pydata theme :) i just applied the update and magic happened ✨ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants