Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup pr with readme and contributing edits following pyopensci review #449

Merged
merged 3 commits into from
Oct 28, 2019

Conversation

lwasser
Copy link

@lwasser lwasser commented Oct 28, 2019

this addresses #443 as a part of our pyopensci review!!
it also addresses #444 which asks for the contributing file to be cleaned up - it has some markdown links rather than rst!!

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #449   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          25     25           
  Lines        1660   1660           
=====================================
  Hits         1577   1577           
  Misses         83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ccd2f...0a2034d. Read the comment docs.

@lwasser lwasser merged commit 3d2dda1 into master Oct 28, 2019
@lwasser lwasser deleted the add-citation-contributing-fix branch December 3, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants