Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Finally add python3-dev to OCI image building #934

Merged
merged 1 commit into from
May 3, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented May 3, 2023

It looks like the main intention of GH-933, to add python3-dev, got lost somehow. Apologies.

@amotl amotl requested a review from gutzbenj May 3, 2023 12:44
@amotl amotl mentioned this pull request May 3, 2023
@amotl
Copy link
Member Author

amotl commented May 3, 2023

I am not merging it, because you could take it as an opportunity to improve/fix the failing radar test cases here? Or will this detail be significantly changing with GH-904 anyway?

-- #816 (comment)

@gutzbenj
Copy link
Member

gutzbenj commented May 3, 2023

Will fix radar tests first, then you can rebase and merge! Basically it seems moduleflag was dropped in the radar files.

@amotl
Copy link
Member Author

amotl commented May 3, 2023

Will fix radar tests first, then you can rebase and merge.

Thank you.

Basically it seems moduleflag was dropped in the radar files.

Maybe @kmuehlbauer knows anything about it?

@gutzbenj
Copy link
Member

gutzbenj commented May 3, 2023

After checking moduleflag is only partly the problem. Also now for multiple tests no radarlocations are provided in data.

@amotl
Copy link
Member Author

amotl commented May 3, 2023

Radar test fixes will happen at GH-935. Thanks!

@amotl amotl merged commit 407fe8f into main May 3, 2023
@amotl amotl deleted the amo/improve-dockerfiles3 branch May 3, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants