Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite and extend Caveats #180

Merged
merged 4 commits into from
Jun 13, 2017
Merged

rewrite and extend Caveats #180

merged 4 commits into from
Jun 13, 2017

Conversation

Larivact
Copy link
Contributor

@Larivact Larivact commented Jun 4, 2017

"inherent limitation in wikicode" sounds misleading it's about generating an AST instead of HTML. #179

"inherent limitation in wikicode" sounds misleading it's about generating an AST instead of HTML.
@earwig
Copy link
Owner

earwig commented Jun 4, 2017

This is good, but I would broaden the scope of the second bullet to mention other cases where template-sensitive information is unavailable. For example, if I created {{bold-end}} as </b>, then MWPFH won't parse <b>foobar{{bold-end}} correctly for the same reason. This often comes up in the context of tables—people like to construct table headers/footers from multiple templates but then use the raw syntax in the middle.

@Larivact
Copy link
Contributor Author

Larivact commented Jun 4, 2017

I think {{bold-end}} would be a bad example since it doesn't make any sense.
Can you give me a simple example that actually makes sense?

@earwig
Copy link
Owner

earwig commented Jun 4, 2017

@Larivact
Copy link
Contributor Author

Larivact commented Jun 4, 2017

I don't get it why wouldn't you just use |}?

@earwig
Copy link
Owner

earwig commented Jun 4, 2017

Semantic clarity? I don't use it, but it exists.

>not supported, since they cannot be represented in the node tree.
It's not that they cannot be represented, it's that they would have to be evaluated.
@Larivact
Copy link
Contributor Author

Larivact commented Jun 4, 2017

I fundamentally rewrote it. I think it's way more clear now.

@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Coverage remained the same at 98.971% when pulling 2d89f61 on Larivact:patch-1 into d7c755f on earwig:develop.

@lahwaacz
Copy link
Contributor

lahwaacz commented Jun 4, 2017

While you're at it, you could also add this (feel free to copy-paste):

And a paragraph about language constructs depending on the MediaWiki configuration. In particular:

I only did a quick sweep through the existing issues, there might be more worth to mention.

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 98.971% when pulling 4d4a251 on Larivact:patch-1 into d7c755f on earwig:develop.

@Larivact
Copy link
Contributor Author

Larivact commented Jun 5, 2017

I renamed Caveats to Limitations since it's more descriptive and added a new "Configuration unawareness" section with the issues you suggested, only slightly reworded. I didn't add #55 since it isn't an inherent limitation (it could be fixed) and it isn't configuration-dependent.

@Larivact Larivact changed the title partially rewrite Caveats, external link caveat rewrite and extend Caveats Jun 5, 2017
@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 98.971% when pulling 2e486f7 on Larivact:patch-1 into d7c755f on earwig:develop.

@earwig
Copy link
Owner

earwig commented Jun 13, 2017

Sorry, got a bit distracted and lost track of this. Thanks for helping out; I will accept this, make some changes, and update the web docs.

@earwig earwig merged commit 9317b52 into earwig:develop Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants