Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wikilink.args for File: links #301

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ctrlcctrlv
Copy link

@ctrlcctrlv ctrlcctrlv commented Jan 30, 2023

Closes #136.

Fails single test I'm not sure how to repair.

@coveralls
Copy link

Coverage Status

Coverage: 99.001% (-0.2%) from 99.2% when pulling 55a0971 on ctrlcctrlv:filelinks into f963df7 on earwig:main.

super().__init__()
self.title = title
self.text = text
self.args = args
if args is not None:
Copy link

@adrianfagerland adrianfagerland Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using self.args instead of args for the check of ...is not None
At least, that solved an error I was getting when using your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip_code() needs special case for [[File:...]] links and interwiki links
3 participants