Skip to content

Commit

Permalink
8332632: Redundant assert(false, "compiler should always document fai…
Browse files Browse the repository at this point in the history
…lure: %s" with possible UB
  • Loading branch information
eastig committed May 24, 2024
1 parent 239c1b3 commit ff2e7ed
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/hotspot/share/compiler/compileBroker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2315,8 +2315,7 @@ void CompileBroker::invoke_compiler_on_method(CompileTask* task) {
DirectivesStack::release(directive);

if (!ci_env.failing() && !task->is_success()) {
assert(ci_env.failure_reason() != nullptr, "expect failure reason");
assert(false, "compiler should always document failure: %s", ci_env.failure_reason());
assert(ci_env.failure_reason() != nullptr, "compiler should always document failure");
// The compiler elected, without comment, not to register a result.
// Do not attempt further compilations of this method.
ci_env.record_method_not_compilable("compile failed");
Expand Down

0 comments on commit ff2e7ed

Please sign in to comment.