-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TradeTax > ExemptionReasonCode #48
Conversation
@pableu see code style test. |
@PATROMO fixed, thanks :) |
@pableu thanks. Can you extend the Test |
I can, but I'd have to set it to null or also modify The former seems a bit silly, and the latter feels wrong because it's an "official example" and I'd feel bad about modifying it. Also, anything else than What do you think? Silly test with Or a whole new test? I don't feel confident about adding a completely new test and new test data. |
@pableu, you can extend the test |
This issue is done with #60. Gonna close this PR. |
No description provided.