Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom easyblock for Flang #1729
base: develop
Are you sure you want to change the base?
add custom easyblock for Flang #1729
Changes from 12 commits
8da54ad
630d7b9
3867285
9c8e478
bfef553
3906f13
e7add2e
b62a1d4
165224f
26e0f95
95f1bad
6855c07
16c1afa
53575df
948894b
ed026f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also drop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I need to override what is in the clang easyblock here which attempts to patch files in the runtime (these do not exist for Flang).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we added Clang as a dependency I think it would be possible to just point to that
libomp
at this point (and not build Flanglibomp
at all).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would likely want Clang+Flang as a single entity, just like we just merged icc/ifort
It makes for a much improved user experience not to have to understand that both icc and ifort have to be loaded despite Lmods spider saying you only need one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Flang, I don't think that is actually a good idea. Flang is (unfortunately) working off forked versions of Clang/LLVM.
This is likely to very soon be out of date anyway...though I admit to being confused by the whole thing:
f18
was supposed to replaceflang
but it seems it will actually take over the nameflang
(see here). Once that get's a release then it is very likely that incorporating flang will become a whole lot easier...it is probably best to wait it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit dubious about whether this is enough, there are a number of libomp libraries in that directory but this is the only one that appears in the Flang Binary Release File List at https://github.com/flang-compiler/flang/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also concerned that an identical library (same source code) is created by Clang, are these compatible?