Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OpenFOAM easyblock to support installation on Arm/aarch64 systems #2162

Merged
merged 3 commits into from
Sep 7, 2020
Merged

fix OpenFOAM easyblock to support installation on Arm/aarch64 systems #2162

merged 3 commits into from
Sep 7, 2020

Conversation

terjekv
Copy link
Contributor

@terjekv terjekv commented Sep 3, 2020

  • More aarch64 compatibility fixes.
  • Different versions of OpenFOAM use different abbreviations for ARM64, or Arm64...

@boegel boegel added the aarch64 Related to Arm 64-bit (aarch64) label Sep 3, 2020
@ocaisa
Copy link
Member

ocaisa commented Sep 4, 2020

@terjekv Can you close #2161 since this one replaces it?

@terjekv terjekv mentioned this pull request Sep 4, 2020
Closed
@terjekv
Copy link
Contributor Author

terjekv commented Sep 4, 2020

Sorted. They were supposed to be compatible, but the develop merging seems to have gone awry. Sorry. :-(

@terjekv
Copy link
Contributor Author

terjekv commented Sep 4, 2020

A test report is on its way, it'll take a few hours due to both OpenFOAM variants needing a full build.

@terjekv
Copy link
Contributor Author

terjekv commented Sep 7, 2020

This is odd, I ran a test report with the easyblock, but I'm not sure where the test result ended up?

@boegel
Copy link
Member

boegel commented Sep 7, 2020

This is odd, I ran a test report with the easyblock, but I'm not sure where the test result ended up?

You hit a known bug that we haven't fixed yet, see easybuilders/easybuild-framework#3289

Your test report is there though, there's just no corresponding comment for it: https://gist.github.com/terjekv/993437e9e5b14f67e68a33dc57f54809

boegel
boegel approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.0) milestone Sep 7, 2020
@boegel boegel changed the title Different OpenFOAM variants are... different. fix OpenFOAM easyblock to support installation on Arm/aarch64 systems Sep 7, 2020
@boegel boegel merged commit f50a85d into easybuilders:develop Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
aarch64 Related to Arm 64-bit (aarch64)
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@terjekv @ocaisa @boegel