Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix version check in Qt5 easyblock w.r.t. disabling features on old Linux kernel versions #2220

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix version check in Qt5 easyblock w.r.t. disabling features on old Linux kernel versions #2220

merged 1 commit into from
Nov 6, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 6, 2020 •
edited
Loading

(created using eb --new-pr)

Without this building old Qt5 versions fails with errors like:

-no-feature-getentropy: invalid command-line switch

@boegel boegel added the bug fix label Nov 6, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 6, 2020
@boegel boegel requested a review from ocaisa November 6, 2020 12:49
ocaisa
ocaisa approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.10(.1) still installs with the broken easyblock, 5.9.x doesn't
Using the updated easyblock fixed the installation of Qt5 5.9.x (and 5.8.x)

@ocaisa ocaisa merged commit 3df929a into easybuilders:develop Nov 6, 2020
@boegel boegel deleted the 20201106120906_new_pr_oKcSlPGjxC branch November 6, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @ocaisa