Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make version regex in OpenSSL wrapper easyblock less strict (version string does not always end with a letter) #2597

Merged

Conversation

akesandgren
Copy link
Contributor

(created using eb --new-pr)

@akesandgren
Copy link
Contributor Author

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/fe9346f89eb97f4deb7c3180250e837e for a full test report.

@akesandgren
Copy link
Contributor Author

akesandgren commented Oct 12, 2021

Without this fix it fails to correctly detect that Ubuntu Bionic libssl1.1 version 1.1.1-1ubuntu2.1~18.04.13 really is a 1.1.1 version.
The version string in libssl.so is:

strings /usr/lib/x86_64-linux-gnu/libssl.so.1.1 | grep OpenSSL
OpenSSL 1.1.1  11 Sep 2018

@akesandgren
Copy link
Contributor Author

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
skalman.hpc2n.umu.se - Linux ubuntu 18.04, x86_64, Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz, Python 3.6.9
See https://gist.github.com/a2977a2cf13853fc598f608acaaf4912 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 13, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2633.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4e01ec8237eb7392a58b5fe6a6858da5 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 13, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenSSL-1.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3530.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f2016200f7d927364543a46ccad3671c for a full test report.

@boegel boegel merged commit b818b88 into easybuilders:develop Oct 13, 2021
@akesandgren akesandgren deleted the 20211012145549_new_pr_openssl_wrapper branch October 14, 2021 05:55
@boegel boegel changed the title openssl_wrapper easyblock version regex is too specific, the version string does not always end with a letter. make version regex in OpenSSL wrapper easyblock less strict (version string does not always end with a letter) Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants