-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance Clang easyblock to add support for building with AMDGPU offload #2684
enhance Clang easyblock to add support for building with AMDGPU offload #2684
Conversation
Note that this addition also makes a slight change to the OpenMP offloading checks for CPU and Nvidia. This was done to clean up handling for the different architectures. I have tested these changes with Clang going back to 9.0.1 with and without CUDA and AMDGPU (only tested for version 12 and 13 of Clang) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
# Detect OpenMP support for CPU architecture | ||
arch = get_cpu_architecture() | ||
# Check architecture explicitly since Clang uses potentially | ||
# different names | ||
if arch == X86_64: | ||
arch = 'x86_64' | ||
elif arch == POWER: | ||
arch = 'ppc64' | ||
elif arch == AARCH64: | ||
arch = 'aarch64' | ||
else: | ||
print_warning("Unknown CPU architecture (%s) for OpenMP library check!" % arch) | ||
custom_paths['files'].extend(["lib/libomptarget.%s" % shlib_ext, | ||
"lib/libomptarget.rtl.%s.%s" % (arch, shlib_ext)]) | ||
# If building for CUDA check that OpenMP target library was created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been version restricted as it is causing sanity checks to fail with Clang-11.0.1-GCCcore-10.2.0.eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said that because of https://gist.github.com/boegelbot/952bd8e34ed36a074a6e1fb7ad4f0ad9 but waiting on other test reports to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocaisa Worked fine with Clang-11.0.1-gcccuda-2020b.eb
though in my test report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, being investigated, may have just been a fluke
(created using
eb --new-pr
)