Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't enable building of ld.gold when installing binutils on a RISC-V system + don't configure GCC to use gold as default linker on a RISC-V system #2780

Merged
merged 4 commits into from
Aug 31, 2022
Merged

don't enable building of ld.gold when installing binutils on a RISC-V system + don't configure GCC to use gold as default linker on a RISC-V system #2780

merged 4 commits into from
Aug 31, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 23, 2022

No description provided.

@boegel boegel added the bug fix label Aug 23, 2022
@boegel boegel added this to the 4.x milestone Aug 23, 2022
@boegel
Copy link
Member Author

boegel commented Aug 23, 2022

@SebastianAchilles I've opened this as a draft PR, because the logic in gcc.py w.r.t. use_gold_linker will need some love, I think. As it is now, it will still enable gold for GCC < 11.3 even on a RISC-V system, I think...

@SebastianAchilles SebastianAchilles mentioned this pull request Aug 23, 2022
Closed
@SebastianAchilles SebastianAchilles linked an issue Aug 23, 2022 that may be closed by this pull request
binutils fails on RISC-V due to ld.gold #2777
Closed
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

Build succeeded for 1 out of 2 (2 easyconfigs in total)
eb-riscv - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (riscv64), Python 3.10.4
See https://gist.github.com/ca0c9b231b2f6f6aae42d78d96749d3b for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.26.eb
  • SUCCESS binutils-2.28.eb
  • SUCCESS binutils-2.30.eb
  • SUCCESS binutils-2.30-GCCcore-7.3.0.eb
  • SUCCESS binutils-2.31.1.eb
  • SUCCESS binutils-2.32.eb
  • SUCCESS binutils-2.34.eb
  • SUCCESS binutils-2.35.eb
  • SUCCESS binutils-2.36.1.eb
  • SUCCESS binutils-2.36.1-GCCcore-8.4.0.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.38.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS GCCcore-8.1.0.eb
  • SUCCESS GCCcore-8.2.0.eb
  • SUCCESS GCCcore-8.3.0.eb
  • SUCCESS GCCcore-9.1.0.eb
  • SUCCESS GCCcore-9.2.0.eb
  • SUCCESS GCCcore-9.3.0.eb
  • SUCCESS GCCcore-9.4.0.eb
  • SUCCESS GCCcore-9.5.0.eb
  • SUCCESS GCCcore-10.1.0.eb
  • SUCCESS GCCcore-10.2.0.eb
  • SUCCESS GCCcore-10.3.0.eb
  • SUCCESS GCCcore-11.1.0.eb
  • SUCCESS GCCcore-11.2.0.eb
  • SUCCESS GCCcore-11.3.0.eb
  • SUCCESS GCCcore-12.1.0.eb
  • SUCCESS GCCcore-12.2.0.eb
  • SUCCESS binutils-2.30-GCCcore-8.1.0.eb
  • SUCCESS binutils-2.31.1-GCCcore-8.2.0.eb
  • SUCCESS binutils-2.32-GCCcore-8.3.0.eb
  • SUCCESS binutils-2.32-GCCcore-9.2.0.eb
  • SUCCESS binutils-2.34-GCCcore-10.1.0.eb
  • SUCCESS binutils-2.34-GCCcore-9.3.0.eb
  • SUCCESS binutils-2.35-GCCcore-10.2.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-10.3.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-11.1.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-9.4.0.eb
  • SUCCESS binutils-2.37-GCCcore-11.2.0.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.38-GCCcore-12.1.0.eb
  • SUCCESS binutils-2.38-GCCcore-9.5.0.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb

Build succeeded for 44 out of 44 (44 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/6aa8f2332ee4882353ce675252718dee for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.28.eb
  • SUCCESS binutils-2.30.eb
  • SUCCESS binutils-2.31.1.eb
  • SUCCESS binutils-2.32.eb
  • SUCCESS binutils-2.34.eb
  • SUCCESS binutils-2.35.eb
  • SUCCESS binutils-2.36.1.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.38.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS GCCcore-7.3.0.eb
  • SUCCESS GCCcore-8.2.0.eb
  • SUCCESS GCCcore-8.3.0.eb
  • SUCCESS GCCcore-9.3.0.eb
  • SUCCESS GCCcore-9.4.0.eb
  • SUCCESS GCCcore-9.5.0.eb
  • SUCCESS GCCcore-10.1.0.eb
  • SUCCESS GCCcore-10.2.0.eb
  • SUCCESS GCCcore-10.3.0.eb
  • SUCCESS GCCcore-11.2.0.eb
  • SUCCESS GCCcore-11.3.0.eb
  • SUCCESS GCCcore-12.1.0.eb
  • SUCCESS GCCcore-12.2.0.eb
  • SUCCESS binutils-2.31.1-GCCcore-8.2.0.eb
  • SUCCESS binutils-2.32-GCCcore-8.3.0.eb
  • SUCCESS binutils-2.34-GCCcore-10.1.0.eb
  • SUCCESS binutils-2.34-GCCcore-9.3.0.eb
  • SUCCESS binutils-2.35-GCCcore-10.2.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-10.3.0.eb
  • SUCCESS binutils-2.37-GCCcore-11.2.0.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.38-GCCcore-12.1.0.eb
  • SUCCESS binutils-2.38-GCCcore-9.5.0.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb

Build succeeded for 34 out of 34 (34 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a331169c7cf5e79b015b4f797aec66e1 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

* **SUCCESS** _binutils-2.38.eb_

* **FAIL (build issue)** _GCCcore-11.3.0.eb_ (partial log available at https://gist.github.com/85a533c2305b34c76c878d69447bb4cf)

Build succeeded for 1 out of 2 (2 easyconfigs in total) eb-riscv - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (riscv64), Python 3.10.4 See https://gist.github.com/ca0c9b231b2f6f6aae42d78d96749d3b for a full test report.

Looks like I am hitting the bug described in https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106271
I think this is more related to the RISC-V Ubuntu image itself rather than the EasyBlock.

@boegel boegel marked this pull request as ready for review August 25, 2022 16:25
@boegel
Copy link
Member Author

boegel commented Aug 25, 2022

@SebastianAchilles I agree, the problem you're hitting is clearly not due the changes being made here.

The updated logic makes sense to me, the test reports on non-RISC-V systems check out, so let's go ahead and merge this?

@boegel boegel modified the milestones: 4.x, next release (4.6.1?) Aug 25, 2022
branfosj
branfosj approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit baea83c into easybuilders:develop Aug 31, 2022
@boegel boegel deleted the riscv branch August 31, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branfosj branfosj branfosj approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

binutils fails on RISC-V due to ld.gold
3 participants
@boegel @SebastianAchilles @branfosj