Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let MATLAB easyblock raise an error if the MATLAB installation key is not provided #2905

Merged
merged 3 commits into from
Apr 12, 2023
Merged

let MATLAB easyblock raise an error if the MATLAB installation key is not provided #2905

merged 3 commits into from
Apr 12, 2023

Conversation

branfosj
Copy link
Member

It makes more sense to me to fail out if the MATLAB install key is not set, rather than install nothing.

@branfosj branfosj mentioned this pull request Mar 16, 2023
Merged
@boegel boegel added this to the next release (4.7.2?) milestone Mar 28, 2023
boegel
boegel requested changes Mar 28, 2023
View reviewed changes
easybuild/easyblocks/m/matlab.py Outdated Show resolved Hide resolved
@boegel boegel changed the title Fail out if the MATLAB install key is not set let MATLAB easyblock raise an error if the MATLAB installation key is not provided Apr 12, 2023
@boegel
Copy link
Member

boegel commented Apr 12, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MATLAB-2021b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/42ec7ec4b315c5e8ffea853300e5b373 for a full test report.

boegel
boegel approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 8bf2d90 into easybuilders:develop Apr 12, 2023
@branfosj branfosj deleted the matlab-install-key branch April 12, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @boegel