Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test suite: stop testing with Python 3.5 and Lmod 6.x, stop using toolchain.DUMMY #3014

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix test suite: stop testing with Python 3.5 and Lmod 6.x, stop using toolchain.DUMMY #3014

merged 3 commits into from
Oct 5, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 5, 2023 •
edited
Loading

@boegel boegel added EasyBuild-5.0 EasyBuild 5.0 bug fix labels Oct 5, 2023
@boegel boegel added this to the 5.0 milestone Oct 5, 2023
@boegel boegel mentioned this pull request Oct 5, 2023
Merged
@boegel boegel changed the title fix test suite: stop testing with Python 3.5, stop using toolchain.DUMMY fix test suite: stop testing with Python 3.5 and Lmod 6.x, stop using toolchain.DUMMY Oct 5, 2023
bartoldeman
bartoldeman reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bartoldeman bartoldeman merged commit 387b071 into easybuilders:5.0.x Oct 5, 2023
@boegel boegel deleted the 5.0.x_fix_test_suite branch October 6, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
bug fix EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @bartoldeman