-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Python bundles and packages to specify a maximum Python version for the system toolchain #3431
allow Python bundles and packages to specify a maximum Python version for the system toolchain #3431
Conversation
… based easyconfigs
…e and also implement in pythonbundle
… a maximum version
…k, there the req_py_majver and friends are guaranteed to be defined
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) Expected failure that confirms that the new functionality works. I used Python 3.12 for a ReFrame version (from easybuilders/easybuild-easyconfigs#21307) that only supports Python <= 3.11.
|
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
Redoing all test builds to make sure things still work. |
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) Reworded the debug message a bit:
|
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
@casparvl I did a search for edit: added two tests in casparvl#4. |
Add two tests for the max_py_* parameters
@bedroge I merged your unit test. Is there anything else that needs to be done for this PR to be merged? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Test report by @bedroge Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
@casparvl What is the intended semantic for specifying only a major version? I would expect that |
We implement support for specifying a maximum python version for EasyConfigs that use system python (through the
max_py_majver
,max_py_minver
keywords). This is is required for easybuilders/easybuild-easyconfigs#21307 which has one EasyConfig that will only work on the python 3.6 - 3.11 range (3.12 will fail because the setuptools is too old, but newer setuptools do not supportpython3.6
).This PR is built on top of #3430 . That one should probably be reviewed & merged first, after which this PR should be synced with develop.