Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gromacs: make it possible to disable single precision as build target. #3501

Merged

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Nov 7, 2024

(created using eb --new-pr)

This is required to be able to build GROMACS-LS 2016.3 which is double precision only,
and this feature should have been there from the beginning.

@akesandgren
Copy link
Contributor Author

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS MDStress-20191228-gfbf-2023a.eb
  • SUCCESS GROMACS-LS-2016.3-foss-2023a.eb

Build succeeded for 2 out of 2 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/akesandgren/5d160f0919f34a8c5565f918cb00edfa for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm since åke insist on being lazy

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Nov 13, 2024

Another test report since I don't have the easyconfig in question please

@akesandgren
Copy link
Contributor Author

Another test report since I don't have the easyconfig in question please

easybuilders/easybuild-easyconfigs#21800

@Micket Micket merged commit 57c0eae into easybuilders:develop Nov 13, 2024
41 checks passed
@akesandgren akesandgren deleted the 20241107124117_new_pr_gromacs branch November 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants