Add support for STAR-CCM+ installs with .aol installer #3510
Conversation
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
| def extract_step(self): | ||
| # Siemens distributions are tarballs or executables with .aol extension | ||
| if self.src[0]['name'].endswith('.aol'): | ||
| self.aol_install = True |
There was a problem hiding this comment.
The source file we got from users is still a tarball file. Maybe this variable can be set by version instead of extension name?
There was a problem hiding this comment.
This should still work for tarballs. It doesn't for you? I'm not sure how Siemens is planning to distribute this (I'm not even sure how they do it now), the idea is that this supports both tarballs and .aol
There was a problem hiding this comment.
I tested with my STAR-CCM easyconfig: (easybuilders/easybuild-easyconfigs#21911) and it looks trying to look for .sh file
$ eb --include-easyblocks-from-pr 3510 STAR-CCM+-19.06.008.eb --rebuild
== Temporary log file in case of crash /dev/shm/eb-4a0mvwcb/easybuild-zfxp_n4p.log
== easyblock star_ccm.py included from PR #3510
== processing EasyBuild easyconfig /apps/c3se-test-easyconfigs/STAR-CCM+-19.06.008.eb
== building and installing STAR-CCM+/19.06.008...
...
FAILED: Installation ended unsuccessfully (build directory: /dev/shm/STARCCM/19.06.008/system-system): build failed (first 300 chars): Was expecting exactly one
match for './STAR-CCM+19.06.008_*.sh', found 0: [] (took 1 min 30 secs)
There was a problem hiding this comment.
Just adding that this didn't work for me either (STAR-CCM+/19.06.009 from a source tarball containing a .aol installer).
There was a problem hiding this comment.
@MaximeVdB The source you have is a tarball containing (only) a .aol file? (I didn't come across that type of source file)
@appolloford Is that the case for your tarball too?
The changes in this PR should only have effect if the source is .aol, so they must have changed their tarballs (?).
Unfortunatelly, I only have a tarball for 18.06.007 to test and it works for that one.
There was a problem hiding this comment.
Here are the content of my tarball
$ ls starccm+_19.06.008/
STAR-CCM+2410_008_linux-x86_64-2.28_gnu11.4.aol doc fnp_LicAdmin.pdf
Siemens has introduced
.aolinstallers for their clang-compiled distributions.Relevant installation Changes:
2410, their clang compiled distributions are.aolexecutables. Other distributions seemed to keep the usual tarball format (which include a.shinstall script). However, STAR-CCM+ compiled with the GCC will no longer be available starting with version2506.2410_008is19.06.008), but .aol use the user facing version in its name.