Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for GCCcore 10.2 to fix __has_include regression #11627

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 7, 2020

(created using eb --new-pr)
This patch is required to fix the compilation of Libint:

python c_to_f.py ../include/libint2.h.i libint2_types_f.h Libint_t
grep '^#' ../include/libint2_types.h | grep -v '#include' > fortran_incldefs.h
FC libint_f.o
../include/libint2/util/generated/libint2_params.h:29:0:
   29 | #    if __has_include(<libint2_params.h>)
      |                                                                                                                                                                                                     Error: missing '(' before __has_include operand                                                                                                                                                           ../include/libint2/util/generated/libint2_params.h:29:0: Error: operator __has_include requires a header-name
make[1]: *** [../MakeSuffixRules:12: libint_f.o] Error 1

see also evaleev/libint#173 + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95889

@boegel boegel added the bug fix label Nov 7, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 7, 2020
@boegel
Copy link
Member Author

boegel commented Nov 7, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11627 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11627 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9709

Test results coming soon (I hope)...

- notification for comment with ID 723431789 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/617b7a5c14bba474f9582f1d6dc713ec for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 7, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3415.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/ff7dd821be7c00eb39acfd11efb7527a for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 7, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/7176b54975ebf047b2635ed48162be82 for a full test report.

@verdurin
Copy link
Member

verdurin commented Nov 7, 2020

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.6
See https://gist.github.com/c9e9f4c85cb9bb50f407ebe6434b0664 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 7, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2406.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/aa79ea67f8fb6f266f144266fac38359 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 7, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/f485a7732456aca94b2ffe80f7b5f532 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 7, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
hebbe-c1 - Linux centos linux 7.8.2003, x86_64, Intel Core Processor (Haswell, no TSX), Python 2.7.5
See https://gist.github.com/853033cffae1f049c4760580571a57a4 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 7, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/3abad380b25333d3e58ea88f4417a7a5 for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 8, 2020

I've re-installed all (105) easyconfigs using GCCcore/10.2.0 as toolchain on top of this, no casualties...

@boegel boegel mentioned this pull request Nov 8, 2020
1 task
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

verdurin commented Nov 8, 2020

Going in, thanks @boegel!

@verdurin verdurin merged commit 7a8a714 into easybuilders:develop Nov 8, 2020
@boegel boegel deleted the 20201107114516_new_pr_GCCcore1020 branch November 8, 2020 11:03
@boegel
Copy link
Member Author

boegel commented Nov 9, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild1.novalocal - Linux centos linux 8.2.2004, POWER, IBM pSeries (emulated by qemu) (power8le), Python 3.6.8
See https://gist.github.com/3f820f076bdb656447674e77fe629c2b for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants