Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Python 2 build dep for nodejs 12.19.0 #11679

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 11, 2020

(created using eb --new-pr)
nodejs v12.19.0 still requires Python 2 as build dep, the configure script explicitly looks for python2 or python2.7:

#!/bin/sh

# Locate python2 interpreter and re-execute the script.  Note that the
# mix of single and double quotes is intentional, as is the fact that
# the ] goes on a new line.
_=[ 'exec' '/bin/sh' '-c' '''
which python2.7 >/dev/null && exec python2.7 "$0" "$@"
which python2 >/dev/null && exec python2 "$0" "$@"
exec python "$0" "$@"
''' "$0" "$@"
]

see #11663 (comment)

@boegel boegel added the bug fix label Nov 11, 2020
@boegel boegel added this to the 4.3.2 milestone Nov 11, 2020
@boegel boegel requested a review from verdurin November 11, 2020 19:51
@boegel
Copy link
Member Author

boegel commented Nov 11, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11679 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11679 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9752

Test results coming soon (I hope)...

- notification for comment with ID 725627284 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member Author

boegel commented Nov 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3626.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2870dc153daba49ab3d352210e885596 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 11, 2020

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/8adb594ff1c0ec59cf3adbd44d5b4d5b for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/59e97645ea58e3a00cd7a3dca6e52fd1 for a full test report.

@Micket
Copy link
Contributor

Micket commented Nov 11, 2020

Going in, thanks @boegel!

@Micket Micket merged commit e84cdda into easybuilders:develop Nov 11, 2020
@boegel
Copy link
Member Author

boegel commented Nov 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2602.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/19ce6281e176d139ca3ddd8aa2059865 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.6
See https://gist.github.com/a6eab8421d5e871bb39fe4a46e2500cb for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cf8fca0f812b4fc83eae5ffb9fcb82a7 for a full test report.

@boegel boegel deleted the 20201111205043_new_pr_nodejs12190 branch November 11, 2020 20:38
@verdurin
Copy link
Member

Going in, thanks @boegel!

1 similar comment
@verdurin
Copy link
Member

Going in, thanks @boegel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants