Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[foss/2020b] carputils v20210513, openCARP v6.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 #12462

Merged
merged 11 commits into from
May 25, 2021
Merged

{bio}[foss/2020b] carputils v20210513, openCARP v6.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 #12462

merged 11 commits into from
May 25, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 23, 2021 •
edited
Loading

(created using eb --new-pr)
requires #12461 (VTK)

@boegel boegel added the update label Mar 23, 2021
@boegelbot

This comment has been minimized.

Sign in to view
@boegel
Copy link
Member Author

boegel commented Mar 24, 2021

@boegelbot please test @ generoso

@boegel boegel added this to the 4.x milestone Mar 24, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12462 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12462 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16417

Test results coming soon (I hope)...

- notification for comment with ID 805583700 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ef8eff66447f59028136f24c9437d064 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 11 out of 18 (7 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.2
See https://gist.github.com/68cb895c6989b9ff42104e80f94df030 for a full test report.

@boegel boegel force-pushed the 20210323210540_new_pr_carputils20210322 branch from 77dabbf to 002ae1c Compare March 31, 2021 11:02
@boegel
Copy link
Member Author

boegel commented Mar 31, 2021

@verdurin Test failed with No space left on device, can you try again?

@boegel
Copy link
Member Author

boegel commented Mar 31, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3552.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/beecdf2226f1a3666dc4d9d68730ae4c for a full test report.

@boegel
use hardcoded '0.0.1-pre' rather than our own self-invited datestamp …
9120611 
…version when ensuring non-0.0.0 version for carputils installation
@boegel
Copy link
Member Author

boegel commented Mar 31, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node2693.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/dd9da4df575b638e5b23ac0fbb5d7a98 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 7 (7 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.2
See https://gist.github.com/6ce891f2460a8d68cca3bccd85f7cc75 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 20 out of 20 (7 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/4b907ada7eef8dc65cd530db600c9e86 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 4 out of 7 (7 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.2
See https://gist.github.com/6f07306200261eb47b3de0c9385c198c for a full test report.

@Flamefire Flamefire mentioned this pull request Apr 1, 2021
Merged
@boegel
Copy link
Member Author

boegel commented Apr 1, 2021

@verdurin Hmm, VTK failed with:

-- Could NOT find Python3 (missing: Development.Module) (found suitable version "3.9.2", minimum required is "3.2")
CMake Error at CMake/vtkModule.cmake:4145 (message):
  Could not find the Python3 external dependency.

But we include Python 3.8.6 as a dependency, so I don't see how that can fail.

Can you check what went wrong there, and perhaps open an issue on it?

@boegel
Copy link
Member Author

boegel commented Apr 4, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12462 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12462 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16489

Test results coming soon (I hope)...

- notification for comment with ID 813060086 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b79401622bec1754ab1dac760453da8f for a full test report.

@boegel boegel changed the title {bio}[foss/2020b] carputils v20210322, openCARP v5.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 {bio}[foss/2020b] carputils v20210322, openCARP v5.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 (WIP) Apr 9, 2021
@boegel
Copy link
Member Author

boegel commented Apr 9, 2021

I marked this as WIP because the researcher reported some problems with this installation.

It's unclear whether the issue is with carputils or with the openCARP 5.0 dependency at this point, hopefully we'll get a better view on that soon...

The software is functional, but seems to be producing slightly incorrect results.

@boegel boegel changed the title {bio}[foss/2020b] carputils v20210322, openCARP v5.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 (WIP) {bio}[foss/2020b] carputils v20210513, openCARP v6.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 (WIP) May 18, 2021
@boegel
Copy link
Member Author

boegel commented May 18, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Member Author

boegel commented May 18, 2021

Updated to latest openCARP and carputils versions, keeping as WIP for now until I hear back from the researchers to see if these versions work as expected...

@boegel boegel marked this pull request as draft May 18, 2021 15:18
@boegel boegel force-pushed the 20210323210540_new_pr_carputils20210322 branch from 34f8092 to acb9af6 Compare May 18, 2021 15:21
@easybuilders easybuilders deleted a comment from boegelbot May 18, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12462 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12462 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17251

Test results coming soon (I hope)...

- notification for comment with ID 843260893 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/42318b63799b3aaeaf2153e5505c952e for a full test report.

@boegel boegel marked this pull request as ready for review May 24, 2021 15:25
@boegel boegel changed the title {bio}[foss/2020b] carputils v20210513, openCARP v6.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 (WIP) {bio}[foss/2020b] carputils v20210513, openCARP v6.0, meshtool v16, meshalyzer v2.2 w/ Python 3.8.6 May 24, 2021
@boegel
Copy link
Member Author

boegel commented May 24, 2021

The researchers have confirmed that the installations provided via these easyconfigs work as expected, so this should be good to go now...

@boegel boegel requested a review from verdurin May 24, 2021 18:09
@boegel
Copy link
Member Author

boegel commented May 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3561.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/09638f4d048d7f6f5896ba0bbc961207 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
select-pika-c6gd-2xlarge-0002 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/1fb3464930772f9e5ed4d2c8e69caba7 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (7 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/01fbd09a338d66e21ef7dc0882253bf3 for a full test report.

verdurin
verdurin approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @boegel!

@verdurin verdurin merged commit ecee182 into easybuilders:develop May 25, 2021
@boegel boegel deleted the 20210323210540_new_pr_carputils20210322 branch May 25, 2021 08:57
@boegel boegel modified the milestones: 4.x, 4.4.0 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@boegel @boegelbot @verdurin