-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use correct Matlab Runtime Compiler (v8.4) for FreeSurfer v7.1.1 #13375
use correct Matlab Runtime Compiler (v8.4) for FreeSurfer v7.1.1 #13375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i guess this looks good to me.
Normally, modifying existing easyconfigs is something to strive to avoid. Perhaps this is a case where the runtime version should be added as a suffix to the easyconfig, to allow it to be distinguished. Though, reading the homepage, it seems like it should have been version 8.4 all along? I'm not entirely sure here.
any opinion on this @sassy-crick ? |
Looking at the documentation it looks like the correct MCR is 8.4. I guess that would qualify as a patch-fix. There was no particular reason for me to pick the older version, I probably have just used the already existing EC file as a template and did not dig any deeper as it all was "working" for me. |
…asyconfigs into 20210707172409_new_pr_FreeSurfer711
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @btlindert! |
(created using
eb --new-pr
)