-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EGL in recent libepoxy easyconfigs #13684
Enable EGL in recent libepoxy easyconfigs #13684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
My only worry, was there any good reason to ever disable this? I mean normally we enable anything we, and EGL is good stuff, so, why..? |
Test report by @Micket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, please add in egl.h
and egl_generated.h
in the sanity check as well for consistency.
@Micket It looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@bogelbot please test @ generoso |
Test report by @Micket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You accidentally removed libepoxy-1.5.4-GCCcore-8.3.0.eb
completely, (and I somehow missed that when reviewing first)
Sorry! I only meant to remove it from this PR (since the Mesa it depends on was built without EGL), not delete it. Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ generoso |
Test report by @Micket |
@Micket: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 896641502 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @jfgrimm! |
(created using
eb --new-pr
)Fixes issue #11197. libepoxy already loads Mesa, which depends on libglvnd and provides libEGL.