Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix installation of easybuild-easyconfigs with setuptools>=61 by explicitly declaring there are no Python packages #15206

Merged
merged 1 commit into from
May 25, 2022

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Mar 30, 2022

fixes #790

Tested with:

$ python3 -m venv
$ source venv/bin/activate
$ cd easybuild-framework/
$ pip install .
$ cd ../easybuild-easyblocks/
$ pip install .
$ cd ../easybuild-easyconfigs/
$ pip install .

And $ eb --search pytorch shows expected output.

Two tests with:

  • updating setuptools to latest (61.2.0)
  • using EB installed Python 3.9.5, which has 56.0.0
  • using OS Python 3.6.8 which has 39.2.0

@boegel boegel added the bug fix label Mar 30, 2022
@boegel boegel added this to the release after 4.5.4 milestone Mar 30, 2022
@branfosj
Copy link
Member Author

We might want to add a test install github action - for several python versions:

  • update setuptools and pip
  • install framework develop
  • install blocks develop
  • install easyconfigs PR

The downside of such testing is that it will cause a failure of PRs that is unrelated to the contents of the PR.

@boegel boegel changed the title fix install with setuptools>=61 fix installation with setuptools>=61 by explicitly declaring there are no Python packages Apr 27, 2022
@boegel
Copy link
Member

boegel commented Apr 27, 2022

@branfosj We could test this in a separate workflow, that runs daily (rather than running it on PRs)

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the source tarball that's created with python3 setup.py sdist with and without this change (using setuptools 57.4.0), they're identical (other than the setup.py itself), so good to go...

Thanks @branfosj!

@boegel boegel merged commit 8f8a1ca into easybuilders:develop May 25, 2022
@branfosj branfosj deleted the setuptools branch May 25, 2022 06:59
@boegel boegel changed the title fix installation with setuptools>=61 by explicitly declaring there are no Python packages fix installation of easybuild-easyconfigs with setuptools>=61 by explicitly declaring there are no Python packages Jun 7, 2022
@akesandgren
Copy link
Contributor

Does this solve easybuilders/easybuild-framework#3984 too?

@boegel
Copy link
Member

boegel commented Jun 20, 2022

@akesandgren Yes, it should indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install easybuild-easyconfigs using pip if setuptools>61
3 participants