Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace sed commands by upstreamed patches for BLIS built with intel-compilers toolchain #15958

Merged
merged 1 commit into from
Aug 29, 2022
Merged

replace sed commands by upstreamed patches for BLIS built with intel-compilers toolchain #15958

merged 1 commit into from
Aug 29, 2022

Conversation

bartoldeman
Copy link
Contributor

(created using eb --new-pr)

@bartoldeman
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bartoldeman: Request for testing this PR well received on login1

PR test command 'EB_PR=15958 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15958 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8937

Test results coming soon (I hope)...

- notification for comment with ID 1202905586 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/faf867734b3fc34c16530270c2dc573a for a full test report.

@bartoldeman bartoldeman added this to the next release (4.6.1?) milestone Aug 5, 2022
akesandgren
akesandgren approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @bartoldeman!

@akesandgren akesandgren merged commit ca2637a into easybuilders:develop Aug 29, 2022
@boegel boegel changed the title BLIS with intel compilers: replace sed commands by upstreamed patches replace sed commands by upstreamed patches for BLIS built with intel-compilers toolchain Aug 31, 2022
@boegel boegel added the change label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
change code cleanup
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bartoldeman @boegelbot @akesandgren @boegel