Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix missing sync in LINCS and SETTLE CUDA kernels for GROMACS 2021 versions #16026

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 10, 2022

@boegel boegel added the bug fix label Aug 10, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Aug 10, 2022
@boegel boegel changed the title Add missing sync in LINCS and SETTLE CUDA kernels for GROMACS 2021 versions add patch to fix missing sync in LINCS and SETTLE CUDA kernels for GROMACS 2021 versions Aug 10, 2022
@SebastianAchilles
Copy link
Member

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16026 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16026 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1450

Test results coming soon (I hope)...

- notification for comment with ID 1211721124 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (5 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/1568a5ae3c4fb8b6c27620170e45fa9d for a full test report.

@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16026 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16026 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9002

Test results coming soon (I hope)...

- notification for comment with ID 1212100681 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/66e62bc1fa5935a4da57f1ed078249db for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 12 out of 12 (5 easyconfigs in total)
bear-pg0104u09a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/34e0ccc9d71d20684bd6238623d65c5e for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit 2f86031 into easybuilders:develop Aug 11, 2022
@branfosj branfosj deleted the 20220810213529_new_pr_GROMACS20212 branch August 11, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants