-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix checksum for Stacks v2.62 (due to silent re-release without version bump) #16134
fix checksum for Stacks v2.62 (due to silent re-release without version bump) #16134
Conversation
Diff between old source tarball (downloaded on 2022-08-08 when testing #15997) and new source tarball (downloaded today, 2022-08-26): $ diff -ru stacks-2.62.old stacks-2.62.new
diff -ru stacks-2.62.old/ChangeLog stacks-2.62.new/ChangeLog
--- stacks-2.62.old/ChangeLog 2022-06-28 20:09:25.000000000 +0000
+++ stacks-2.62.new/ChangeLog 2022-07-26 19:23:17.000000000 +0000
@@ -6,6 +6,9 @@
Feature: improved ustacks logging to include final number of assembled
loci; modified denovo_map.pl to include this in its logging output.
Improved logging in populations program.
+ Feature: Added variant of PstI cutsite to process_radtags: pstishi only
+ leaves "GCAG" as the cutsite remnant, published in:
+ Shirasawa, Hirakawa, and Isobe, 2016, DNA Research; doi: 10.1093/dnares/dsw004
Bugfix: fixed assert() failure in populations when no population map was
specified.
Bugfix: updated stacks-dist-extract --pretty print to better handle
Binary files stacks-2.62.old/libcore.a and stacks-2.62.new/libcore.a differ
diff -ru stacks-2.62.old/scripts/denovo_map.pl stacks-2.62.new/scripts/denovo_map.pl
--- stacks-2.62.old/scripts/denovo_map.pl 2022-06-20 15:33:24.000000000 +0000
+++ stacks-2.62.new/scripts/denovo_map.pl 2022-08-08 18:32:59.000000000 +0000
@@ -894,7 +894,7 @@
Stack assembly options:
-M: number of mismatches allowed between stacks within individuals (for ustacks).
- -n: number of mismatches allowed between stacks between individuals (for cstacks; default 1; suggested: set to ustacks -M).
+ -n: number of mismatches allowed between stacks between individuals (for cstacks; default: set to ustacks -M).
SNP model options:
--var-alpha: significance level at which to call variant sites (for gstacks; default: 0.05).
diff -ru stacks-2.62.old/src/renz.cc stacks-2.62.new/src/renz.cc
--- stacks-2.62.old/src/renz.cc 2021-11-16 19:16:06.000000000 +0000
+++ stacks-2.62.new/src/renz.cc 2022-07-26 19:20:29.000000000 +0000
@@ -112,6 +112,9 @@
"GCTCGA", "CCTCGA", "ACTCGA"};
const char *pstI[] = {"TGCAG", // CTGCA/G, PstI
"CTGCA"};
+const char *pstIshi[] = {"GCAG", // CTGCA/G, PstI;
+ "CTGC"}; // Modified so that "CT" is part of the Illumina sequencing primer and not in the final sequence.
+ // As published in Shirasawa, Hirakawa, and Isobe, 2016, DNA Research; doi: 10.1093/dnares/dsw004
const char *rsaI[] = {"AC", // GT/AC, RsaI
"GT"};
const char *sacI[] = {"AGCTC", // GAGCT/C, SacI
@@ -140,6 +143,7 @@
renz["sbfI"] = sbfI; // CCTGCA/GG, SbfI
renz["pstI"] = pstI; // CTGCA/G, PstI
+ renz["pstIshi"] = pstIshi; // CTGCA/G, PstI-SHI
renz["notI"] = notI; // GC/GGCCGC, NotI
renz["ecoRI"] = ecoRI; // G/AATTC, EcoRI
renz["nspI"] = nspI;
@@ -199,6 +203,7 @@
renz_cnt["sbfI"] = 1;
renz_cnt["pstI"] = 1;
+ renz_cnt["pstIshi"] = 1;
renz_cnt["notI"] = 1;
renz_cnt["ecoRI"] = 1;
renz_cnt["nspI"] = 2;
@@ -258,6 +263,7 @@
renz_len["sbfI"] = 6;
renz_len["pstI"] = 5;
+ renz_len["pstIshi"] = 4;
renz_len["notI"] = 6;
renz_len["ecoRI"] = 5;
renz_len["nspI"] = 5; |
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1228240190 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1228297771 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
Test report by @sassy-crick |
I think this should really get a separate version.... |
Like what? By changing the checksum people should notice that something is wrong if they try to install without re-downloading |
@akesandgren As discussed, since this version of Stacks was only merged into |
Yes good to merge, processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @boegel! |
(created using
eb --new-pr
)