-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patches for Ambertools 21 to Amber 20.11 to work with new Amber easyblock #16343
add patches for Ambertools 21 to Amber 20.11 to work with new Amber easyblock #16343
Conversation
Required after easybuilders/easybuild-easyblocks#2781 (in EasyBuild 4.6.1) |
I am not sure why, but the patches were not required for the fosscuda variant https://github.com/zemu-unile/easybuild-easyconfigs/blob/20220930160030_new_pr_Amber2011/easybuild/easyconfigs/a/Amber/Amber-20.11-fosscuda-2020b-AmberTools-21.3.eb |
Tests depend on #16166 |
That's because that specific easyconfig doesn't run the tests at all. |
…asyconfigs into 20220930160030_new_pr_Amber2011
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Still having problems with alt_location and checksum verification.
Test report by @akesandgren |
We need easybuilders/easybuild-framework#4093 to make alt_location and patch checksumming work for Amber since there are old versions of at least one patch still in Amber while we now use the one from AmberTools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @zemu-unile! |
(created using
eb --new-pr
)Patches were taken from #16151