Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{numlib}[foss/2023a] Suitesparse v7.1.0 #18857

Conversation

appolloford
Copy link
Contributor

@appolloford appolloford commented Sep 25, 2023

@akesandgren
Copy link
Contributor

Test report by @akesandgren
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3004
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.147.05, Python 3.10.12
See https://gist.github.com/akesandgren/add52f953d38387377f716cba735d922 for a full test report.

@akesandgren
Copy link
Contributor

Test report by @akesandgren
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3004
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.147.05, Python 3.10.12
See https://gist.github.com/akesandgren/5ad1504dfa04b31a9607236aa8c4d562 for a full test report.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @appolloford!

@akesandgren
Copy link
Contributor

Going in, thanks @appolloford!

@akesandgren akesandgren merged commit 39f09d5 into easybuilders:develop Nov 8, 2023
('MPFR', '4.2.0'),
]

prebuildopts = 'CMAKE_OPTIONS="-DCMAKE_INSTALL_PREFIX=%(installdir)s -DBLA_VENDOR=FlexiBLAS"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appolloford Can't we enhance the SuiteSparse easyblock to also take care of this automatically?

At least the -DCMAKE_INSTALL_PREFIX=%(installdir)s should be done automatically, as accidentally not including this in the easyconfig would be rather dramatic...

Even the -DBLA_VENDOR part can be derived automatically from the toolchain.

We could still leave the door open to specify custom options for CMake in the easyconfig, but I would do that via a direct custom easyconfig parameter that is supported by the SuiteSparse custom easyblock, like:

cmake_options = "..."

If cmake_options is set, that value could then also be included in the CMAKE_OPTIONS="..." that the SuiteSparse easyblock constructs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it will require a somewhat larger rewrite of the easyblock. It would need to find each dir which should be built with CMake etc since there currently is no top level CMakeLists.txt that does the right thing.

I didn't want to delay the easyblock PR to make this happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make the CMAKE_OPTIONS set in easyblock, and actually I tried that before. I did not know how to add a local option for a particular easyconfigs, but I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants