Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geotiff configure option in GDAL #19999

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 29, 2024

(created using eb --new-pr)

It has always been with-geotiff not with-libgeotiff

I didn't update the 2018* ECs as they'll be hard to test... But the same applies there. So if we don't need test reports I can update them too.

@ocaisa ocaisa added this to the release after 4.9.0 milestone Feb 29, 2024
@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3026"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19999 EB_ARGS="--include-easyblocks-from-pr 3026" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19999 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12995

Test results coming soon (I hope)...

- notification for comment with ID 1971318805 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

I hadn't realised the easyconfigs were so old, this is very likely to fail the builds

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 5 out of 6 (5 easyconfigs in total)
n1327 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/986d8910dd43074e1812c801682c4ce6 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3026
FAILED
Build succeeded for 6 out of 14 (9 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d7be6c9688f80af5f659858a23e63fae for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Feb 29, 2024

The fix is good, and unrelated to the build failures (very old toolchains, mostly failures related to Intel compiler license)

@ocaisa ocaisa merged commit 987d2c0 into easybuilders:develop Feb 29, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240229110401_new_pr_GDAL202 branch March 1, 2024 09:48
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 20 out of 20 (5 easyconfigs in total)
i8013 - Linux Rocky Linux 8.7 (Green Obsidian), x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.8.13
See https://gist.github.com/Flamefire/cf0be0c96525eee5abf7584eb68bb921 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants