-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libjpeg-turbo dependency for torchvision #20437
add libjpeg-turbo dependency for torchvision #20437
Conversation
@smoors Isn't this also relevant for more recent versions of |
yes, was planning to, but got side-tracked. is already fixed for
still to do:
|
@boegelbot: please test @ generoso |
@smoors: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2099016221 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
you meant 6 minutes ago ;)
it doesn't have any effect as we are already setting note that you slipped in |
on second thought, i think it's better to fix this in the easyblock |
It was a genuine question, I wasn't pretending I'm all-knowing here... :) |
('PyTorch', '1.12.0', '-CUDA-%(cudaver)s'), | ||
] | ||
|
||
preinstallopts = 'WITH_CUDA=1 TORCHVISION_INCLUDE="$EBROOTLIBJPEGMINTURBO/include:$TORCHVISION_INCLUDE"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going forward with easybuilders/easybuild-easyblocks#3322 (which makes sense), we should clean this up accordingly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can just close this PR, as libjpeg-turbo is already a dep of Pillow-SIMD?
once the easyblock is merged i'll remove the TORCHVISION_INCLUDE from the easyconfigs that have it set
closing in favor of easybuilders/easybuild-easyblocks#3322 |
(created using
eb --new-pr
)